docs(tutorial): note depreciation of global hooks #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hpincket
commented
Jun 13, 2015
hpincket
commented
- remove global hook code example
- add mention of middleware
- add reference link to middleware
- remove global hook code example - add mention of middleware - add reference link to middleware
|
👍 |
| .. code:: python | ||
|
|
||
| falcon.API(before=[extract_project_id]) | ||
| initializer, though this has been depreciated in favor of middleware. |
There was a problem hiding this comment.
I think it may be even better to simply not mention how hooks can be applied globally, specifically:
- In L551, remove the "or even globally" clause.
- In L561-L563, say something about how logic can also be applied globally using middleware (with no mention of global hooks)
Typo: "depreciated" ==> "deprecated"
|
@hpincket Just following up to get your thoughts on my inline comment? |
* In L551, remove the "or even globally" clause. * In L561-L563, remove reference to global hooks leaving middleware only
|
@kgriffs Ah, silly mistakes. I've made the suggested changes. |
|
Looks good, thanks! |
kgriffs
added a commit
that referenced
this pull request
Jul 14, 2015
docs(tutorial): note depreciation of global hooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.