Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional HTTP status codes #559

Merged
merged 2 commits into from
Jul 1, 2015
Merged

Add additional HTTP status codes #559

merged 2 commits into from
Jul 1, 2015

Conversation

chripede
Copy link
Contributor

Implement error codes from http://tools.ietf.org/html/rfc6585
Fixes #553

@kgriffs
Copy link
Member

kgriffs commented Jul 1, 2015

@chripede This looks good, thanks! Not a big deal, but for next time it would be great if you could follow the commit message format as specified here:

https://github.com/falconry/falcon/blob/master/CONTRIBUTING.md#commit-message-format

@@ -90,6 +90,12 @@
HTTP_IM_A_TEAPOT = HTTP_418
HTTP_426 = '426 Upgrade Required'
HTTP_UPGRADE_REQUIRED = HTTP_426
HTTP_428 = '428 Precondition Required'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add some subclasses of HTTPError that correspond to these...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added #561

kgriffs added a commit that referenced this pull request Jul 1, 2015
Add additional HTTP status codes
@kgriffs kgriffs merged commit a9946d7 into falconry:master Jul 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants