Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated quickstart examples to inherit from object (new-style classes) #575

Merged

Conversation

adamyala
Copy link

I went through the docs page by page and looked for where a class declaration was missing the new object inheritance.

@adamyala
Copy link
Author

This pull request is in response to
#565

I wasn't sure if there was a way to link issues to pull requests

@kgriffs
Copy link
Member

kgriffs commented Aug 3, 2015

@adamyala This change looks good. Could you ammend your commit message slightly in preparation for merging? It should conform to our style guide, and you can reference the issue in the body, i.e.:

doc(quickstart): Update examples to use new-style classes

Closes #565

@adamyala adamyala force-pushed the update_documentation_to_inherit_from_object branch from b91c2ce to c6388fc Compare August 10, 2015 22:32
@adamyala
Copy link
Author

@kgriffs I rebased my commits to use the style guide (and also just used the example you gave me)

The last thing I'm not 100% clear on is the Travis CI build check. Anything specific I should do about it? Is there a type of pull request when I'd want to address it?

Sorry for all the questions, I'm new to open source contributing. I'm also working on another open issue and I'd like to save us the trouble later.

@kgriffs
Copy link
Member

kgriffs commented Aug 11, 2015

The last thing I'm not 100% clear on is the Travis CI build check. Anything specific I should do about it? Is there a type of pull request when I'd want to address it?

For this particular change, there isn't anything to do. But if you were to modify the framework code then you would have to ensure that the tests pass, and if there aren't any tests that cover the change already, add some new ones until all code paths are tested. You can run the tests locally per the instruction on the README. It's a good idea to at least run pep8, py27, and py34 before submitting the PR:

$ tox -e pep8,py27,py34

If everything passes, you can submit the PR and Travis will test the remainder of the environments for you. Let me know if that helps, and feel free to catch me anytime on Freenode in #falconframework if you have further questions; I'm always happy to help new open-source contributors. 👍

kgriffs added a commit that referenced this pull request Aug 11, 2015
…_from_object

Updated quickstart examples to inherit from object (new-style classes)
@kgriffs kgriffs merged commit d73fc18 into falconry:master Aug 11, 2015
@kgriffs
Copy link
Member

kgriffs commented Aug 11, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants