feat(testing): Add TestClient class and a pytest example #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,23 +16,51 @@ | |||
|
|
|||
| This package contains various test classes and utility functions to | |||
| support functional testing for both Falcon-based apps and the Falcon | |||
| framework itself:: | |||
| framework itself. Both unittest-style and pytest-style tests are | |||
| supported:: | |||
There was a problem hiding this comment.
Please carefully review the example code below for correctness. Thanks!
Current coverage is 100% (diff: 100%)@@ master #862 diff @@
====================================
Files 30 30
Lines 1867 1875 +8
Methods 0 0
Messages 0 0
Branches 305 305
====================================
+ Hits 1867 1875 +8
Misses 0 0
Partials 0 0
|
kgriffs
force-pushed
the
issue-16-pytest
branch
from
66a6898
to
80637ca
Compare
| class MyTestCase(testing.TestCase): | ||
| def setUp(self): | ||
| super(MyTestCase, self).setUp() | ||
| self.app = api.create() |
There was a problem hiding this comment.
Perhaps I'm just missing something, but where is create() defined? is that just hypothetical for the example?
There was a problem hiding this comment.
Just hypothetical... let me try to add a comment or something to avoid confusion. 😄
There was a problem hiding this comment.
OK, I tweaked this. Let me know if it makes more sense!
kgriffs
force-pushed
the
issue-16-pytest
branch
2 times, most recently
from
d65f62b
to
d7ed940
Compare
| super(TestMyApp, self).setUp() | ||
| self.api = app.create_api() | ||
| super(MyTestCase, self).setUp() | ||
| self.app = api.create() |
There was a problem hiding this comment.
You probably want to add that comment about create() here as well.
There was a problem hiding this comment.
Ah, nice catch! Will do.
kgriffs
force-pushed
the
issue-16-pytest
branch
from
492d795
to
6183803
Compare
added 2 commits
August 16, 2016 23:58
Add a contextual wrapper for the simulate_* methods and a pytest example demonstrating its use. Also deprecate "api" in favor of "app" in TestCase, since these utils can work with any WSGI app (not just those that express HTTP APIs). This terminology makes TestCase more consistent with the new simulate_* functions and with TestClient. Finally, deprecate "api_class" in TestCase and update the docstring for the testing module to demonstrate a less hacky alternative for controlling the api instance type. As a bonus, this avoids having to try and alias api_class (a class variable). Partially implements falconry#16
kgriffs
force-pushed
the
issue-16-pytest
branch
from
6183803
to
a6672ee
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a contextual wrapper for the simulate_* methods and a pytest
example demonstrating its use.
Also deprecate "api" in favor of "app" in TestCase, since these utils
can work with any WSGI app (not just those that express HTTP APIs). This
terminology makes TestCase more consistent with the new simulate_*
functions and with TestClient.
Finally, deprecate "api_class" in TestCase and update the docstring
for the testing module to demonstrate a less hacky alternative for
controlling the api instance type. As a bonus, this avoids having to
try and alias api_class (a class variable).
Partially implements #16