Add 'docker.io/falcosecurity/falco' image to 'falco_privileged_images' macro #56
Conversation
|
Welcome @nvanheuverzwijn! It looks like this is your first PR to falcosecurity/charts 🎉 |
Add 'docker.io/falcosecurity/falco' image to 'falco_privileged_images' macro. This preven messages like this when booting up falco : ``` Warning Pod started with privileged container (user=system:serviceaccount:kube-system:daemon-set-controller pod=falco-42brw ns=monitoring images=docker.io/falcosecurity/falco:0.24.0) ``` Signed-off-by: Nicolas Vanheuverzwijn <nicolas.vanheu@gmail.com>
|
I removed chart update and changelog changes. I will let the owners do the release or create a release on another PR. |
There was a problem hiding this comment.
Hello @nvanheuverzwijn ! Thanks for this contribution 👏
Anyways, rules here a just a mirror of the default (and official) Falco rule sets in https://github.com/falcosecurity/falco
Thus I invite you to send this same PR to that repository!
|
@leodido Sounds good! I will re-open the PR if this gets merged upstream! Thank you very much! Cheers! |
|
@leodido Looks like this change has been approved upstream already (so fast!) -> falcosecurity/falco#1326 Maybe we can reopen this PR and merge it ? How do you want to proceed ? |
|
LGTM label has been added. Git tree hash: 51807259c14191f156e3761d44686a06757db2b4
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area falco-chart
What this PR does / why we need it:
Prevent warning message from falco when booting falco itself. Below is a sample message :