Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(k8s-metacollector): correctly indent the service monitor #607

Merged

Conversation

alacuku
Copy link
Member

@alacuku alacuku commented Jan 25, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area event-generator-chart

/area k8s-metacollector

What this PR does / why we need it:

fix(k8s-metacollector): correctly indent the service monitor

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

Signed-off-by: Aldo Lacuku <aldo@lacuku.eu>
@poiana poiana added kind/chart-release Add this label when the chart version has been bumped dco-signoff: yes labels Jan 25, 2024
@poiana poiana requested review from bencer and cpanato January 25, 2024 16:31
@poiana poiana added the size/S label Jan 25, 2024
@poiana
Copy link
Contributor

poiana commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Jan 25, 2024

LGTM label has been added.

Git tree hash: 276817dcb90dcab94af2e4f6b3030e3a773804ce

@poiana poiana merged commit 9e37025 into falcosecurity:master Jan 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes kind/chart-release Add this label when the chart version has been bumped lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants