-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected the link to values falcosidekick #610
Conversation
Corrected the link to values falcosidekick Signed-off-by: kiper-prog <45040023+kiper-prog@users.noreply.github.com>
Welcome @kiper-prog! It looks like this is your first PR to falcosecurity/charts 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
/approve
thanks!
LGTM label has been added. Git tree hash: d063566512664035226ea05a66a11c7292cf6d7a
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, kiper-prog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change is correct, and the link should be also fix in that sectionhttps://github.com/falcosecurity/charts/tree/master/charts/falco#deploy-falcosidekick-with-falco.
FYI: the PR can't be merged, the CI requires to update the changelog, and bump up the version in the Chart.yaml, for both falco and sidekick charts (because we change files in the both charts)
Issues go stale after 90d of inactivity. Mark the issue as fresh with Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with Provide feedback via https://github.com/falcosecurity/community. /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh with Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with Provide feedback via https://github.com/falcosecurity/community. /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue with Mark the issue as fresh with Provide feedback via https://github.com/falcosecurity/community. |
@poiana: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Corrected the link to values falcosidekick
What type of PR is this?
/kind documentation
Any specific area of the project related to this PR?
/area falco-chart
What this PR does / why we need it: Corrected the link to values falcosidekick
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist