Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected the link to values ​​falcosidekick #610

Closed
wants to merge 1 commit into from

Conversation

kiper-prog
Copy link

Corrected the link to values ​​falcosidekick

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area event-generator-chart

/area k8s-metacollector

What this PR does / why we need it: Corrected the link to values ​​falcosidekick

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

Corrected the link to values ​​falcosidekick

Signed-off-by: kiper-prog <45040023+kiper-prog@users.noreply.github.com>
@poiana poiana added kind/documentation Improvements or additions to documentation dco-signoff: yes area/falco-chart labels Jan 27, 2024
@poiana
Copy link
Contributor

poiana commented Jan 27, 2024

Welcome @kiper-prog! It looks like this is your first PR to falcosecurity/charts 🎉

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm
/approve

thanks!

@poiana
Copy link
Contributor

poiana commented Jan 28, 2024

LGTM label has been added.

Git tree hash: d063566512664035226ea05a66a11c7292cf6d7a

@poiana
Copy link
Contributor

poiana commented Jan 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, kiper-prog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is correct, and the link should be also fix in that sectionhttps://github.com/falcosecurity/charts/tree/master/charts/falco#deploy-falcosidekick-with-falco.

FYI: the PR can't be merged, the CI requires to update the changelog, and bump up the version in the Chart.yaml, for both falco and sidekick charts (because we change files in the both charts)

@poiana
Copy link
Contributor

poiana commented Apr 28, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@Issif Issif self-assigned this Apr 30, 2024
@poiana
Copy link
Contributor

poiana commented May 28, 2024

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

@poiana
Copy link
Contributor

poiana commented Jun 27, 2024

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana poiana closed this Jun 27, 2024
@poiana
Copy link
Contributor

poiana commented Jun 27, 2024

@poiana: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants