Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add additionalProperties for falcosidekick service Monitor #668

Closed
wants to merge 2 commits into from
Closed

Conversation

ArnaudCHT
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area event-generator-chart

/area k8s-metacollector

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
I've added the capability to the Falco-exporter charts to set additional properties within the Service Monitor, such as relabelings, metricRelabelings, etc.
I ran a Helm template and tested the Service Monitor in an OpenShift cluster.

Checklist

  • Chart Version bumped
  • Variables are documented in the README.md
  • CHANGELOG.md updated

Signed-off-by: Arnaud CHATELAIN <a.chatelain@actongroup.com>
Signed-off-by: Arnaud CHATELAIN <a.chatelain@actongroup.com>
@poiana poiana added kind/feature New feature or request dco-signoff: yes kind/chart-release Add this label when the chart version has been bumped area/falcosidekick-chart labels May 14, 2024
@poiana
Copy link
Contributor

poiana commented May 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArnaudCHT
Once this PR has been reviewed and has the lgtm label, please assign issif for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from bencer and Issif May 14, 2024 20:38
@poiana poiana added the size/S label May 14, 2024
@ArnaudCHT ArnaudCHT closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/falcosidekick-chart dco-signoff: yes kind/chart-release Add this label when the chart version has been bumped kind/feature New feature or request size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants