Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(docs): fixed command for running privileged ebpf falco docker. #1301

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

terylt
Copy link
Contributor

@terylt terylt commented Mar 25, 2024

The existing privileged docker command for running ebpf incorrectly tries to load the kmod, while running falco in ebpf mode. By adding an environment variable we force the container to load the ebpf probe. The command was also missing the falco cli.

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area documentation

What this PR does / why we need it:

It fixes the docker command for loading the ebpf version of falco. The current command errors in two ways:

  1. Since it doesn't have falco in it, docker incorrectly thinks the executable is -o
  2. The docker container loads the kmod probe, but falco is loaded in ebpf mode.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

The existing privileged docker command for running ebpf incorrectly tries to load the kmod, while running falco in ebpf mode.  By adding an environment variable we force the container to load the ebpf probe.  The command was also missing the `falco` cli.

Signed-off-by: terylt <30874627+terylt@users.noreply.github.com>
Copy link
Contributor

@LucaGuerra LucaGuerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@poiana
Copy link

poiana commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LucaGuerra, terylt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Mar 25, 2024

LGTM label has been added.

Git tree hash: 383bd34b87e175ce07b597a9eedda351427fbb92

@poiana poiana merged commit 36b8837 into falcosecurity:master Mar 25, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants