fix(cmake/modules): update driver to support kernels 5.6.y #1174
Conversation
Co-authored-by: Lorenzo Fontana <lo@linux.com> Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
|
/cc @fntlnz |
|
/approve |
|
LGTM label has been added. Git tree hash: d3ec353cbeccc49cee536bda2bb18ff69f8b5417
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, kris-nova The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
So I think this broke our driver build. Has anyone been able to compile the driver with this new version? I am testing on 4.19.118 and will report my findings. |
|
@kris-nova - Can you post more details? You mean the process of building a driver from source or our automated driver building process? I tested with against the longterm kernels and @nathan-b - the actual patch author also tested in their environment: draios/sysdig#1621 (comment) |
|
Also thanks for testing this out @kris-nova we definitely need to understand what happened to your build before we release because releasing a broken driver might be a huge deal for the project |
|
Our automated tests have been running with this change (both eBPF and kmod) for nearly a week now. I'm not saying that I didn't break anything, but I don't think I broke everything ;) |
|
So this is ready to ship into the next Falco release! Thanks for the fix @nathan-b ! |
Co-authored-by: Lorenzo Fontana lo@linux.com
Signed-off-by: Leonardo Di Donato leodidonato@gmail.com
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1173
Refs draios/sysdig#1621
Special notes for your reviewer:
Does this PR introduce a user-facing change?: