Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(systemd): solve some issues with systemd unit #2385

Merged
merged 2 commits into from
Jan 28, 2023
Merged

update(systemd): solve some issues with systemd unit #2385

merged 2 commits into from
Jan 28, 2023

Conversation

Andreagit97
Copy link
Member

@Andreagit97 Andreagit97 commented Jan 27, 2023 •
edited
Loading

What type of PR is this?

/kind bug

/kind cleanup

Any specific area of the project related to this PR?

/area engine

What this PR does / why we need it:

This PR solves some issues with systemd units.

  1. With the actual implementation systemd restart and systemd condrestart cause:

    Transaction contains conflicting jobs 'restart' and 'stop' for falcoctl-artifact-follow.service. Probably contradicting requirement dependencies configured.

    This issue is solved by removing the Conflicts= directive. The Conflicts= directive was here just to protect users from running more than one Falco instance with systemd, but since this causes issues we prefer to disable this behavior allowing to use restart/condrestart commands

  2. The PR provides a new environment variable to disable the dialog at installation time FALCO_FRONTEND, if you don't want the dialog enabled by default when starting the unit you should use FALCO_FRONTEND=noninteractive. Examples:

    sudo FALCO_FRONTEND=noninteractive apt install falco 
sudo FALCO_FRONTEND=noninteractive yum install falco

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@Andreagit97
update(systemd): solve some issues with systemd unit
33b723e 
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
@poiana poiana requested review from Kaizhe and leogr January 27, 2023 10:15
FedeDP
FedeDP previously approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Jan 27, 2023
@poiana
Copy link
Contributor

poiana commented Jan 27, 2023

LGTM label has been added.

Git tree hash: 05b2110ffcccc37c8ddb24d82a2f14ca9bc155b9

@Andreagit97
Copy link
Member Author

/hold for testing

leogr
leogr previously approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/milestone 0.34.0

@poiana poiana added this to the 0.34.0 milestone Jan 27, 2023
@Andreagit97
fix: configure_file in CMake
627b884 
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
@Andreagit97 Andreagit97 dismissed stale reviews from leogr and FedeDP via 627b884 January 27, 2023 12:49
@poiana poiana removed the lgtm label Jan 27, 2023
@poiana poiana requested review from FedeDP and leogr January 27, 2023 12:49
FedeDP
FedeDP approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Fix!
/approve

@poiana poiana added the lgtm label Jan 27, 2023
@poiana
Copy link
Contributor

poiana commented Jan 27, 2023

LGTM label has been added.

Git tree hash: dea95b7ca096b4323f8a2e6583cdecda6b0ffe8d

@FedeDP
Copy link
Contributor

FedeDP commented Jan 27, 2023

Tested and works like a charm on rpm based distro!

@poiana
Copy link
Contributor

poiana commented Jan 27, 2023

@therealbobo: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana
Copy link
Contributor

poiana commented Jan 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce, therealbobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Andreagit97
Copy link
Member Author

/unhold

@poiana poiana merged commit 660da98 into falcosecurity:master Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealbobo therealbobo therealbobo approved these changes

@jasondellaluce jasondellaluce jasondellaluce approved these changes

@FedeDP FedeDP FedeDP approved these changes

@Kaizhe Kaizhe Awaiting requested review from Kaizhe

@leogr leogr Awaiting requested review from leogr

Assignees

@leogr leogr

@FedeDP FedeDP

@jasondellaluce jasondellaluce

Labels
approved area/engine dco-signoff: yes kind/bug kind/cleanup lgtm release-note-none size/S
Projects
None yet
Milestone
0.34.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Andreagit97 @poiana @FedeDP @leogr @jasondellaluce @therealbobo