Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci,build): fixes for 0.35.x release branch #2622

Merged

Conversation

LucaGuerra
Copy link
Contributor

@LucaGuerra LucaGuerra commented Jun 7, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug
/area build
/area ci

What this PR does / why we need it:

Changes for build issue identified on the Falco 0.35.x release branch

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Luca Guerra <luca@guerra.sh>
Signed-off-by: Luca Guerra <luca@guerra.sh>
Copy link
Contributor

@jasondellaluce jasondellaluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jun 7, 2023

LGTM label has been added.

Git tree hash: 24e22438ad3ababf656dfc3d5770e3c438d39e5c

@poiana poiana added the approved label Jun 7, 2023
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jun 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, jasondellaluce, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeDP
Copy link
Contributor

FedeDP commented Jun 7, 2023

/milestone 0.35.0

This is the very same patch as #2621.
To speed up, we are opening the PR against the release branch.

@poiana poiana added this to the 0.35.0 milestone Jun 7, 2023
@FedeDP FedeDP mentioned this pull request Jun 7, 2023
63 tasks
@FedeDP
Copy link
Contributor

FedeDP commented Jun 7, 2023

tide — In merge pool.

Please tide.

@poiana poiana merged commit faa915d into falcosecurity:release/0.35.x Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants