Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: cleanup(config): new json_output_properties flags and output options consolidation #2670

Closed
wants to merge 3 commits into from

Conversation

incertum
Copy link
Contributor

@incertum incertum commented Jul 5, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:

Redesign JSON log output fields options and expose configuration for most fields to give adopters more options to tailor the space of the log while maintaining backward compatibility.

This feature was requested by the community, CC @misterjulien

@jasondellaluce could get the python tests to run locally, but most of them failed meaning I am a bit unclear re how to add new tests to this PR , marking it as wip in the interim. Hoping you could give some pointers, thank you!

Which issue(s) this PR fixes:

#2628

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

cleanup(config): new json_output_properties flags and output options consolidation

Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
…ut_properties flags

Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
@poiana
Copy link
Contributor

poiana commented Jul 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: incertum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the approved label Jul 5, 2023
@poiana poiana requested review from Kaizhe and LucaGuerra July 5, 2023 17:44
@poiana poiana added the size/L label Jul 5, 2023
@incertum
Copy link
Contributor Author

incertum commented Jul 5, 2023

/milestone 0.36.0

@poiana poiana added this to the 0.36.0 milestone Jul 5, 2023
@incertum incertum modified the milestones: 0.36.0, 0.37.0 Aug 23, 2023
@Andreagit97 Andreagit97 modified the milestones: 0.37.0, TBD Aug 31, 2023
@poiana
Copy link
Contributor

poiana commented Nov 30, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@incertum
Copy link
Contributor Author

/remove-lifecycle stale

will check if still needed, likely we need a more proper refactor anyways.

@poiana
Copy link
Contributor

poiana commented Feb 28, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@poiana
Copy link
Contributor

poiana commented Mar 29, 2024

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

@poiana
Copy link
Contributor

poiana commented Apr 28, 2024

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana poiana closed this Apr 28, 2024
@poiana
Copy link
Contributor

poiana commented Apr 28, 2024

@poiana: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants