Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(OWNERS): remove inactive approvers #111

Closed
wants to merge 2 commits into from

Conversation

jasondellaluce
Copy link
Contributor

@jasondellaluce jasondellaluce commented Jul 5, 2022

What type of PR is this?

/kind cleanup

/kind documentation

Any specific area of the project related to this PR?

What this PR does / why we need it:

For falcosecurity/evolution#157, this PR moves inactive approvers (who had very little or zero contributions over the past 6 months) from approvers to emeritus_approvers in OWNERS.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
@poiana
Copy link
Contributor

poiana commented Jul 5, 2022

@jasondellaluce: The label(s) area/engine cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind cleanup

/kind documentation

Any specific area of the project related to this PR?

/area engine

What this PR does / why we need it:

For falcosecurity/evolution#157, this PR moves inactive approvers (who had very little or zero contributions over the past 6 months) from approvers to emeritus_approvers in OWNERS.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana
Copy link
Contributor

poiana commented Jul 5, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jasondellaluce
To complete the pull request process, please assign kris-nova after the PR has been reviewed.
You can assign the PR to them by writing /assign @kris-nova in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Copy link
Contributor

@fntlnz fntlnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, I'd remain the only maintainer in this repository.

However, since I'd love to revamp this project and:

I'm ok with keeping anyone willing to help revamp this project and/or onboarding new maintainers.
/cc @falcosecurity/falcoctl-maintainers

Let me know if you're interested.

@poiana poiana requested a review from a team July 13, 2022 09:12
@leogr leogr requested a review from fntlnz July 13, 2022 14:14
@leogr
Copy link
Member

leogr commented Jul 19, 2022

No one from the previous maintainer is interested in maintaining this repo anymore.

@jasondellaluce can I ask you to reopen this PR (to unblock it)?
Afterward, I'll actively find other maintainers since I don't feel totally comfortable remaining alone here.

Thank you in advance.

@jasondellaluce
Copy link
Contributor Author

No one from the previous maintainer is interested in maintaining this repo anymore.

@jasondellaluce can I ask you to reopen this PR (to unblock it)? Afterward, I'll actively find other maintainers since I don't feel totally comfortable remaining alone here.

Thank you in advance.

Closing this and opened #113.

/close

@poiana poiana closed this Jul 19, 2022
@poiana
Copy link
Contributor

poiana commented Jul 19, 2022

@jasondellaluce: Closed this PR.

In response to this:

No one from the previous maintainer is interested in maintaining this repo anymore.

@jasondellaluce can I ask you to reopen this PR (to unblock it)? Afterward, I'll actively find other maintainers since I don't feel totally comfortable remaining alone here.

Thank you in advance.

Closing this and opened #113.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants