add slsa provenance for binaries and sign container images #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @developer-guy! It looks like this is your first PR to falcosecurity/falcoctl 🎉 |
developer-guy
changed the title
poiana
added
do-not-merge/work-in-progress
dco-signoff: no
and removed
dco-signoff: yes
labels
developer-guy
force-pushed
the
feature/container-image-signing-slsa-provenance
branch
from
69c93fc
to
52f853e
Compare
developer-guy
changed the title
developer-guy
force-pushed
the
feature/container-image-signing-slsa-provenance
branch
2 times, most recently
from
d25e2af
to
a883698
Compare
alacuku
reviewed
May 18, 2023
There was a problem hiding this comment.
Hi @developer-guy, thanks for the PR.
Left some minor comments.
alacuku
approved these changes
May 18, 2023
|
LGTM label has been added. Git tree hash: 596b754930ec9e9e7c434ed990084bc82a0b7b20
|
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com> registry username Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com> fix(ci): correct image name Signed-off-by: Luca Guerra <luca@guerra.sh> add new line Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
developer-guy
force-pushed
the
feature/container-image-signing-slsa-provenance
branch
from
f59651f
to
17434dd
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, developer-guy, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Any specific area of the project related to this PR?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: