new(libsinsp/test): Start dedicated container engine unit testsuite w/ mock CRI API response #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
kind/feature
incertum
force-pushed
the
new-container-unit-testsuite
branch
2 times, most recently
from
fe6eceb
to
e099c25
Compare
incertum
commented
Dec 5, 2023
userspace/libsinsp/test/container_engine/container_parser_cri_containerd.ut.cpp
Show resolved
Hide resolved
incertum
force-pushed
the
new-container-unit-testsuite
branch
3 times, most recently
from
0d84700
to
aa619af
Compare
incertum
force-pushed
the
new-container-unit-testsuite
branch
from
aa619af
to
3322719
Compare
Andreagit97
reviewed
Dec 12, 2023
userspace/libsinsp/test/container_engine/container_cache.ut.cpp
Outdated
Show resolved
Hide resolved
userspace/libsinsp/test/container_engine/container_cache.ut.cpp
Outdated
Show resolved
Hide resolved
userspace/libsinsp/test/container_engine/container_parser_cri_containerd.ut.cpp
Show resolved
Hide resolved
userspace/libsinsp/test/container_engine/container_parser_cri_containerd.ut.cpp
Show resolved
Hide resolved
userspace/libsinsp/test/container_engine/container_parser_cri_crio.ut.cpp
Show resolved
Hide resolved
… test Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
…ri parsers Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
Co-authored-by: Andrea Terzolo <andreaterzolo3@gmail.com> Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
…els handling Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
incertum
force-pushed
the
new-container-unit-testsuite
branch
from
2877f8b
to
4c04dfc
Compare
incertum
commented
Dec 12, 2023
userspace/libsinsp/test/container_engine/container_parser_cri_containerd.ut.cpp
Show resolved
Hide resolved
Andreagit97
approved these changes
Dec 13, 2023
| @@ -16,6 +16,11 @@ limitations under the License. | |||
|
|
|||
| */ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #ifndef LIBSINSP_CRI_HPP | |||
There was a problem hiding this comment.
if we use the #pragma once we don't need the header guard #ifndef LIBSINSP_CRI_HPP
|
LGTM label has been added. Git tree hash: 823bb57306f9610bfbbc9b8ba1f1cf9fb9e12241
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, incertum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area tests
Does this PR require a change in the driver versions?
What this PR does / why we need it:
thereby enabling us to test the parser logic.
While we need realistic e2e tests, this will help especially since we are starting to realize that the container engine needs some refactoring. Note that this is a start given the current limitations.
If the other maintainers support this general approach we can continue working on it.
Related to #1298
CC @Andreagit97 and @therealbobo
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: