Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aviator crate #7

Merged
merged 1 commit into from
Jul 8, 2018
Merged

add aviator crate #7

merged 1 commit into from
Jul 8, 2018

Conversation

wowluanoob
Copy link
Contributor

i like this project so i would like to help

i like this project so i would like to help
@wowluanoob
Copy link
Contributor Author

Also you are not calculating steam 15% tax in the EV calculation part
currently its
EV = items_EV - key_price
i propose you make it
EV = items_EV - key_price - (0.15 * items_EV)

@falkben
Copy link
Owner

falkben commented Jul 2, 2018

Thank you for the patch. Typically I add the source to the readme for each crate. Also, I assume the drop rates on the other crates changed as well?

You are correct on the EV calculation part. Should be straightforward to fix.

@wowluanoob
Copy link
Contributor Author

wowluanoob commented Jul 3, 2018 via email

@falkben
Copy link
Owner

falkben commented Jul 8, 2018

At some point I'd like to be able to calculate which crate to get (when they release a new crate, sometimes they offer a choice between random crate drop or new crate with key).

@falkben falkben merged commit be347c0 into falkben:master Jul 8, 2018
@wowluanoob
Copy link
Contributor Author

wowluanoob commented Jul 9, 2018 via email

@wowluanoob
Copy link
Contributor Author

wowluanoob commented Jul 9, 2018 via email

@wowluanoob
Copy link
Contributor Author

also can you show where to edit for us and euro currency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants