feat: change esc to act like cancel for change prompt #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
edit accidentally selected the wrong issue. It should be #32 |
famiu
requested changes
Dec 3, 2022
lua/bufdelete/init.lua
Outdated
| @@ -40,7 +40,7 @@ local function buf_kill(range, force, wipeout) | |||
|
|
|||
| -- If force is disabled, check for modified buffers in range. | |||
| if not force then | |||
| for bufnr, _ in pairs(target_buffers) do | |||
| for bufnr, buf in pairs(target_buffers) do | |||
There was a problem hiding this comment.
Sorry, that was an artifact from a different approach I was taking. I just forgot to remove it.
lua/bufdelete/init.lua
Outdated
| target_buffers[bufnr] = nil | ||
| end | ||
|
|
||
| -- Clear message area. | ||
| cmd.echo('""') | ||
| cmd.redraw() | ||
| end | ||
|
|
lua/bufdelete/init.lua
Outdated
| @@ -55,14 +55,15 @@ local function buf_kill(range, force, wipeout) | |||
|
|
|||
| if choice == 's' or choice == 'S' then -- Save changes to the buffer. | |||
| api.nvim_buf_call(bufnr, function() cmd.write() end) | |||
| elseif choice == 'c' or choice == 'C' then -- Cancel, remove buffer from targets. | |||
| elseif choice ~= 'i' and choice ~= 'I' then -- If not ignored, do not close | |||
There was a problem hiding this comment.
Suggested change
| elseif choice ~= 'i' and choice ~= 'I' then -- If not ignored, do not close | |
| elseif choice ~= 'i' and choice ~= 'I' then -- If not ignored, remove buffer from targets. |
famiu
approved these changes
Dec 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of pressing escape when prompted for changes. Currently, the behavior of escape acts like ignore, allowing the buffer to be closed. This changes the behavior so that it acts like cancel.
Resolves #32
It's a quick hack and may be considered somewhat of a breaking change if folks were accustomed to pressing any key to close.