MacOS compilation modifications for fanckush's PR #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Install `git` before homebrew on systems sans Xcode installation. Some `sudo`s not required for default toolchain build on Sierra+. Remove SYSROOT from cmake command. Swap `libiomp5` for `libomp` in cmake command. `ditto` instead of `cp` to allow upgrades, in case `HDRmerge.app` was previously installed in `/Applications`. Renumbered steps.
|
Nice! thanks.
|
|
The brew installation command (on a base Sierra system) required git to be installed first. If git is present, that step would be skippable of course. Sysroot is for cross compiling across recent/legacy versions of an OS. It references an SDK which is located or manually placed inside the xcode package. Xcode doesn't ship with legacy SDKs, so they must either be salvaged from old xcodes or downloaded from https://github.com/phracker/MacOSX-SDKs/releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install
gitbefore homebrew on systems sans Xcode installation.Some
sudos not required for default toolchain build on Sierra+.Remove SYSROOT from cmake command.
Swap
libiomp5forlibompin cmake command.dittoinstead ofcpto allow upgrades, in caseHDRmerge.appwas previously installed in/Applications.Renumbered steps.