Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loader for XML-based Semeval Datasets #7

Closed
hosseinfani opened this issue Oct 16, 2022 · 7 comments
Closed

Loader for XML-based Semeval Datasets #7

hosseinfani opened this issue Oct 16, 2022 · 7 comments
Assignees
@farinamhz
Labels
enhancement New feature or request

Comments

@hosseinfani
Copy link
Member

Currently, the code has a loader for a csv file (not sure if it's from semeval). We need to add a loader for the official semeval datasets
@hosseinfani hosseinfani added the enhancement New feature or request label Oct 16, 2022
@farinamhz farinamhz assigned DeepKaran1 and unassigned farinamhz Dec 20, 2022
@hosseinfani
Copy link
Member Author

@DeepKaran1
Congrats! You got your first real task.
Can you give me an estimate of when you will finish this task?

@DeepKaran1
Copy link

DeepKaran1 commented Dec 20, 2022 •
edited
Loading

@hosseinfani
Previously I was busy with my exams and just started working on it today. I am unsure about how much time it requires in total from me, instead you can give me a deadline for this, and I will try to finish it before that.

@hosseinfani
Copy link
Member Author

@DeepKaran1
how about a week from now?

@DeepKaran1
Copy link

Dr. Fani I am afraid, as I am in Toronto spending some quality time with my family it will be quite challenging for me, but I will try my best to complete it.

@farinamhz farinamhz assigned farinamhz and unassigned DeepKaran1 Dec 23, 2022
farinamhz added a commit that referenced this issue Dec 27, 2022
@farinamhz
update on XML loader but with problem now (#7)
6dd64a5
farinamhz added a commit that referenced this issue Dec 27, 2022
@farinamhz
xml loader completed (#7)
abb4abc
@farinamhz
Copy link
Member

I need to change the preprocessing on the XML dataset and change the way of tokenizing the sentences to get the index of aspect words.

@hosseinfani
Copy link
Member Author

@farinamhz
also, one remaining task was make the vicabularly the same for all methods.

farinamhz added a commit that referenced this issue Dec 30, 2022
@farinamhz
Update on preprocessing and tokenize method of dataset for XML loader (…
149e9f4 
…#7)
@farinamhz
Copy link
Member

Hi @hosseinfani,
I have updated the XML loader based on what we talked about for tokenizing method.
The vocabulary updates for what you said will be done under issue ( #12 ). Thanks for reminding this task.

@farinamhz farinamhz mentioned this issue Feb 14, 2023
Open
32 tasks
farinamhz added a commit that referenced this issue Feb 17, 2023
@farinamhz
Bug fixed for the xml reader - sentences loader (#7)
296ac7e
hosseinfani added a commit that referenced this issue Apr 25, 2023
@hosseinfani
code refactor xmlloader (#7) (#34)
def18e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@farinamhz farinamhz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hosseinfani @farinamhz @DeepKaran1