Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] - Make splitting currencies optional by player choice #50

Open
gsterling opened this issue Feb 5, 2022 · 8 comments
Open
Labels
enhancement New feature or request help wanted Creator won't implement this feature

Comments

@gsterling
Copy link

Is your feature request related to a problem? Please describe.
Sometimes my players don't want to share the money. But then they still can only take their own share or I have to disable the sharing feature altogether for the chest.

Describe the solution you'd like
When configuring a item pile have the options to "Enable Sharing of currencies" (old) and depending on it the two options "Force sharing" (new) and "Enable split with players button" (old). "Force sharing" would function as it is now with sharing enabled. You can only take your fair share. With "Force sharing" disabled, you'd have the option to take more, than your normal share were or even everything. With inactive "Force Sharing" it would not track the fair share und the button "split with players" would just share everything that is still inside the chest evenly. This way it was more of a quality of life feature, while still giving characters the possibilty to cheat each other.

Describe alternatives you've considered

  • Not allowing my players to have their characters take more than they agreed to.
  • Not sharing at all and have them calculate the money each time.
  • Changing the settings each time someone want to take more than the others or even just edit the amounts by hand.

Additional context

@gsterling gsterling added the enhancement New feature or request label Feb 5, 2022
@Haxxer
Copy link
Collaborator

Haxxer commented Feb 5, 2022

How about a button to forgo your share?

@gsterling
Copy link
Author

Additionally, yes, sounds good.

But not as a solution to my problem as it requires everyone to reach the pile.

@Haxxer Haxxer removed their assignment Sep 22, 2022
@Haxxer Haxxer added the help wanted Creator won't implement this feature label Feb 8, 2023
@kiloforce
Copy link

kiloforce commented Nov 25, 2023

Really cool module! But, my players and I were confused. I dropped 50 gold into a loot drop, but it showed only 8 gold for the player to take. I believe what was happening is it was only displaying an auto divided amount. But, the divided amount was wrong. Also, the loot drop should really at least display in parenthesis the full amount in the loot, for reference.

So, a couple of issues:

50 in loot drop:
image

8 available? 7 players?
image

Issue 1) Why is it only showing 8, not 50? Theory is auto dividing. Can this be disabled? Issue #50 would imply no?

Issue 2) The split amount is wrong anyway. I have 4 players, so the split amount should be 12gp and change, so why is it showing 8? Theory is it is incorretly assuming wrong player count. The button "Split currency 7 ways" would agree. I have a "test" player, and an "observer" player and the players have some summon pets. How exactly is it calculating 7 players, and can I override which players it selects?

Issue 3) Even if it assumes 7 players, and is forcefully pre-dividing the money (theory based on this issue #50), then why isn't it showing 7 gold available? 50 / 7 would be 7 and change,

The easiest solution for all 3 would be an option for the DM to disable this forced auto division. Should still leave the "split currency X ways" button for those that want to auto split. For auto division the module really needs option to override the players. Thanks

@Haxxer
Copy link
Collaborator

Haxxer commented Nov 26, 2023

@kiloforce I would recommend keeping issues in a new ticket so that a request does not become both a bug report and a request ticket.

@Haxxer
Copy link
Collaborator

Haxxer commented Nov 26, 2023

I assume you have not taken a look inside the item piles' setting, because turning off forced splitting can be done here:

image

@kiloforce
Copy link

@Haxxer that's exactly what I am looking for! I looked through all of the module settings, and couldn't find that. Where do I find that setting at?

@Haxxer
Copy link
Collaborator

Haxxer commented Nov 26, 2023

@kiloforce That is in the item piles' settings. You open the item piles UI, then click the box in the header, go into other settings, and it is there. If you set your default item pile to have this disabled, every item pile created from then on will have those settings as well.

The wiki can be found here, as shown on the description on the foundry website, and on this github page:
https://fantasycomputer.works/FoundryVTT-ItemPiles/#/api

@kiloforce
Copy link

@kiloforce That is in the item piles' settings. You open the item piles UI, then click the box in the header, go into other settings, and it is there. If you set your default item pile to have this disabled, every item pile created from then on will have those settings as well.

The wiki can be found here, as shown on the description on the foundry website, and on this github page: https://fantasycomputer.works/FoundryVTT-ItemPiles/#/api

Thanks! I didn't realize it was configurable per pile. That's actually pretty slick. The setting is pretty buried, even knowing what to look for.

Also, found the option for "Split only with 'Active' Players" also helped focus on the auto division, although I do have a "observer" player that I wish I could have it exclude.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Creator won't implement this feature
Projects
None yet
Development

No branches or pull requests

3 participants