Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: additional logging for invalid messages #1699

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

sanjayprabhu
Copy link
Contributor

@sanjayprabhu sanjayprabhu commented Feb 13, 2024

Motivation

Add some more logs for duplicate and delayed messages

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

Focus of this PR:

This PR focuses on improving the handling of gossip messages in the Hub class.

Detailed summary:

  • Added errMsg, fid, and type properties to the gossip message object.
  • Updated the handleContactInfo method to handle contact info content.
  • Changed the reportValid method to be awaited when reporting valid gossip messages.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@sanjayprabhu sanjayprabhu added the t-chore Miscellaneous improvements label Feb 13, 2024
Copy link

changeset-bot bot commented Feb 13, 2024

⚠️ No Changeset found

Latest commit: 1bd1962

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 6:35pm

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1c590a) 74.03% compared to head (1bd1962) 74.62%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1699      +/-   ##
==========================================
+ Coverage   74.03%   74.62%   +0.58%     
==========================================
  Files          99       99              
  Lines        9256     9309      +53     
  Branches     2078     2090      +12     
==========================================
+ Hits         6853     6947      +94     
+ Misses       2282     2249      -33     
+ Partials      121      113       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanjayprabhu sanjayprabhu merged commit 402b678 into farcasterxyz:main Feb 13, 2024
10 checks passed
dtbuchholz pushed a commit to dtbuchholz/hub-monorepo that referenced this pull request Feb 13, 2024
dtbuchholz pushed a commit to dtbuchholz/hub-monorepo that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-chore Miscellaneous improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant