Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix duplicate message ttl check and reduce fname poll timeout #1700

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

sanjayprabhu
Copy link
Contributor

@sanjayprabhu sanjayprabhu commented Feb 13, 2024

Motivation

Seen TTL is in ms, but timestamp is seconds, so the duplicate check never triggered. Also reduce the fname poll timeout so we don't reject username change messages if it came in faster than the old 30 second timeout.

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

This PR focuses on fixing issues related to gossip message handling and reducing poll timeout for fname registry events.

Detailed summary

  • Fixed a bug in gossip seen TTL check by converting it to seconds
  • Reduced the poll timeout for fname registry events from 30 seconds to 5 seconds
  • Reduced the read timeout for fname registry events from 10 seconds to 2.5 seconds
  • Updated the calculation of cutOffTime in hubble.ts to divide GOSSIP_SEEN_TTL by 1000
  • Added logging for peer contact information in syncEngine.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@sanjayprabhu sanjayprabhu added the t-bug A fix for a bug with the current system label Feb 13, 2024
Copy link

changeset-bot bot commented Feb 13, 2024

🦋 Changeset detected

Latest commit: 240b402

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 11:12pm

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (402b678) 74.69% compared to head (240b402) 74.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1700      +/-   ##
==========================================
- Coverage   74.69%   74.57%   -0.13%     
==========================================
  Files          99       99              
  Lines        9309     9308       -1     
  Branches     2090     2090              
==========================================
- Hits         6953     6941      -12     
- Misses       2245     2254       +9     
- Partials      111      113       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanjayprabhu sanjayprabhu merged commit 83f66ab into farcasterxyz:main Feb 13, 2024
10 checks passed
@sanjayprabhu sanjayprabhu deleted the fix_duplication_logic branch February 13, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-bug A fix for a bug with the current system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant