Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove DB_RESET_TOKEN #1704

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

adityapk00
Copy link
Contributor

@adityapk00 adityapk00 commented Feb 16, 2024

Motivation

Remove the DB_RESET_TOKEN env var as a way to reset the DB
Use the dbreset command instead.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR focuses on fixing an issue related to the DB_RESET_TOKEN environment variable in the hubble app.

Detailed summary

  • Removes the usage of DB_RESET_TOKEN and related logic in cli.ts file.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@adityapk00 adityapk00 added the t-bug A fix for a bug with the current system label Feb 16, 2024
@adityapk00 adityapk00 requested a review from sds February 16, 2024 16:59
Copy link

changeset-bot bot commented Feb 16, 2024

🦋 Changeset detected

Latest commit: 0851e83

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 4:59pm

@adityapk00 adityapk00 merged commit 8cfaa2c into farcasterxyz:main Feb 16, 2024
8 checks passed
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (592bbb2) 74.59% compared to head (0851e83) 74.58%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1704      +/-   ##
==========================================
- Coverage   74.59%   74.58%   -0.02%     
==========================================
  Files          99       99              
  Lines        9308     9308              
  Branches     2090     2090              
==========================================
- Hits         6943     6942       -1     
- Misses       2252     2253       +1     
  Partials      113      113              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adityapk00 adityapk00 deleted the removedbtoken branch February 16, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-bug A fix for a bug with the current system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants