Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gossipsub version and "iwant" parameter #1708

Merged
merged 2 commits into from
Feb 17, 2024

Conversation

Wazzymandias
Copy link
Contributor

@Wazzymandias Wazzymandias commented Feb 16, 2024

Motivation

  • Hubs experience spikes of duplicate messages
  • Duplicate messages should not propagate to application layer if seen in p2p layer
  • However, high message throughput can be I/O intensive and delay propagation. Delayed messages can reduce peer scores and yield negative feedback loop.

Change Summary

  • Expose environment variable GOSSIPSUB_IWANT_FOLLOWUP_MS
  • Pass in gossipsubIWantFollowupMs parameter in gossipNodeWorker

Merge Checklist

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

This PR focuses on improving the gossipsub configuration in the LibP2PNode class.

Detailed summary:

  • Added a new environment variable GOSSIPSUB_IWANT_FOLLOWUP_MS to customize the follow-up time in milliseconds.
  • Updated the gossipsub configuration to use the custom follow-up time.
  • Set asyncValidation to true to prevent forwarding known bad messages.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

…@chainsafe/libp2p-gossipsub to 6.3.0, and pass in gossipsubIWantFollowupMs parameter in gossipNodeWorker
Copy link

changeset-bot bot commented Feb 16, 2024

⚠️ No Changeset found

Latest commit: f5e4f7c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 11:55pm

@Wazzymandias Wazzymandias changed the title fix: expose environment variable GOSSIPSUB_IWANT_FOLLOWUP_MS, update … fix: gossipsub version and "iwant" parameter Feb 16, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1a52b86) 74.65% compared to head (f5e4f7c) 74.62%.

Files Patch % Lines
apps/hubble/src/network/p2p/gossipNodeWorker.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1708      +/-   ##
==========================================
- Coverage   74.65%   74.62%   -0.04%     
==========================================
  Files          99       99              
  Lines        9324     9327       +3     
  Branches     2097     2100       +3     
==========================================
- Hits         6961     6960       -1     
- Misses       2250     2254       +4     
  Partials      113      113              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanjayprabhu
Copy link
Contributor

Nice find.

@sanjayprabhu sanjayprabhu marked this pull request as ready for review February 16, 2024 23:58
@sanjayprabhu sanjayprabhu merged commit 38a9ea3 into main Feb 17, 2024
9 of 10 checks passed
@sanjayprabhu sanjayprabhu deleted the fix/gossipsub-iwant-and-version branch February 17, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants