-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: gossipsub version and "iwant" parameter #1708
Conversation
…@chainsafe/libp2p-gossipsub to 6.3.0, and pass in gossipsubIWantFollowupMs parameter in gossipNodeWorker
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1708 +/- ##
==========================================
- Coverage 74.65% 74.62% -0.04%
==========================================
Files 99 99
Lines 9324 9327 +3
Branches 2097 2100 +3
==========================================
- Hits 6961 6960 -1
- Misses 2250 2254 +4
Partials 113 113 ☔ View full report in Codecov by Sentry. |
Nice find. |
Motivation
Change Summary
Merge Checklist
Additional Context
If this is a relatively large or complex change, provide more details here that will help reviewers
PR-Codex overview
This PR focuses on improving the
gossipsub
configuration in theLibP2PNode
class.Detailed summary:
GOSSIPSUB_IWANT_FOLLOWUP_MS
to customize the follow-up time in milliseconds.gossipsub
configuration to use the custom follow-up time.asyncValidation
totrue
to prevent forwarding known bad messages.