Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support keyword argument to initially autocommit=on #12

Merged
merged 5 commits into from
Aug 18, 2013
Merged

Support keyword argument to initially autocommit=on #12

merged 5 commits into from
Aug 18, 2013

Conversation

methane
Copy link
Collaborator

@methane methane commented Jan 31, 2013

To avoid sending 2 unnecessary commands to MySQL when using autocommit mode.

@ghost ghost assigned farcepest May 20, 2013
@farcepest
Copy link
Owner

OK, I support doing this. However, there is a change I'd like to see:

autocommit = True: enables autocommit
autocommit = False: disable autocommit (the default)
autocommit = None: do not change the MySQL connection default

And also I need to save the autocommit state somewhere in the connection object for something else I have planned. The current value can be obtained with SHOW SESSION VARIABLES LIKE 'autocommit' which will be either "ON" or "OFF".

farcepest added a commit that referenced this pull request Aug 18, 2013
Support keyword argument to initially autocommit=on
@farcepest farcepest merged commit c8b2744 into farcepest:master Aug 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants