Use nyc for code coverage reports #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velichkov
force-pushed
the
coverage_nyc
branch
from
026b4fe
to
7888be5
Compare
velichkov
force-pushed
the
coverage_nyc
branch
from
7888be5
to
b16bb30
Compare
npm WARN deprecated istanbul@0.4.5: This module is no longer maintained, try this instead: npm WARN deprecated npm i nyc npm WARN deprecated Visit https://istanbul.js.org/integrations for other alternatives.
velichkov
force-pushed
the
coverage_nyc
branch
from
b16bb30
to
a5859f2
Compare
velichkov
commented
Feb 16, 2022
| "istanbul": "^0.4.3", | ||
| "mocha": "2.x" | ||
| "mocha": "2.x", | ||
| "nyc": "^12.0.2" |
There was a problem hiding this comment.
nyc version 15.1.0 requires node.js >= 8.6 and on 4 and 6 it fails with
https://app.travis-ci.com/github/farhadi/node-smpp/jobs/559932321#L224-L228
https://app.travis-ci.com/github/farhadi/node-smpp/jobs/559932320#L224-L228
All versions after 13.0.1 require find-up version that does not support node.js 4
https://app.travis-ci.com/github/farhadi/node-smpp/jobs/559933794#L301-L304
That is why currently I set the version to 12.0.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm WARN deprecated istanbul@0.4.5: This module is no longer maintained, try this instead:
npm WARN deprecated npm i nyc
npm WARN deprecated Visit https://istanbul.js.org/integrations for other alternatives.