Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For some reason FARM_MAYBE_VARGS is causing issues #98

Merged
merged 3 commits into from
Aug 11, 2023
Merged

For some reason FARM_MAYBE_VARGS is causing issues #98

merged 3 commits into from
Aug 11, 2023

Conversation

Hackerman342
Copy link
Collaborator

@Hackerman342 Hackerman342 commented Jul 31, 2023 •
edited
Loading 

error: expected primary-expression before ')' token
        263 |           __func__ FARM_MAYBE_VARGS(__VA_ARGS__)(__VA_ARGS__));

isherman and others added 3 commits July 23, 2023 23:57
@isherman
Add missing include to logger.h (#94)
f006362
@wylderkeane
Add API for bytes written to EventLogWriter (#95)
b0598a5
@ethanrublee
For some reason this is causing issues for me in a simplified build e…
d803e82 
…nvironment.

error: expected primary-expression before ')' token
        263 |           __func__ FARM_MAYBE_VARGS(__VA_ARGS__)(__VA_ARGS__));
@Hackerman342 Hackerman342 mentioned this pull request Jul 31, 2023
Closed
@ethanrublee ethanrublee changed the base branch from main to event-service-client August 11, 2023 20:23
@ethanrublee ethanrublee marked this pull request as ready for review August 11, 2023 20:23
@ethanrublee
Copy link
Member

I will merge this into event-service-client, and we can get help with getting to main brain later.

@ethanrublee ethanrublee merged commit 1d0855f into event-service-client Aug 11, 2023
5 of 6 checks passed
@ethanrublee ethanrublee deleted the many-hacks-to-logger branch August 11, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Hackerman342 @ethanrublee @isherman @wylderkeane