Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm good separation between farmOS-native and farmOS-client repos #23

Closed
jgaehring opened this issue Apr 27, 2018 · 2 comments
Closed
Labels
duplicate maintenance maintaining developer happiness & hygiene, reducing tech debt

Comments

@jgaehring
Copy link
Member

Here are some known issues:

  • Remove localStorage operations from NewObservation.vue
  • Sort out UI state from Data and Login state (eg, where to put isOnline?)
  • Create an app shell in the client for "global" UI state & components (eg, isOnline)
  • (probably more subtasks to be identified after merging latest)

There is a corresponding issue in farmOS-client

@jgaehring
Copy link
Member Author

Another bit of state that needs to be considered is isWorking in the login module.

This seems to be some state to indicate that the login module is waiting for a response from the server; however, this seems to be more of a UI concern, if its main intent is to communicate to the user that their request is pending. With promise-based AJAX, it shouldn't be necessary to put this kind of information in state just for the sake of keeping track during the request's execution; a Promise object is itself always in 1 of 3 states: pending, fulfilled, or rejected.

Also, it seems that this state is not purely the concern of the login plugin, since the data plugin accesses it regularly as well too. There is also a duplicate piece of state on the client's main store, also called isWorking

@jgaehring jgaehring added duplicate maintenance maintaining developer happiness & hygiene, reducing tech debt labels Aug 1, 2018
@jgaehring
Copy link
Member Author

Closing so this can be tracked in the corresponding client issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate maintenance maintaining developer happiness & hygiene, reducing tech debt
Development

No branches or pull requests

1 participant