-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .getId()
method
#40
Comments
I may wait on this a little longer. I guess I'm just reluctant to add another method like this, expanding the API surface. As an alternative, I wonder if it might make better sense to add an |
I would really recommend against this. The response type is different when you GET a single id as a path argument. From the original farmOS.py issue:
|
Ohhhh, yes, thank you! I was struggling to remember our conversation around this, and yes, I definitely don't want to do this. Ok, I think I will punt on this though for now, at least until there is a clear need for such a method. I'd be inclined to implement it in the standalone export of the |
Similar to farmOS/farmOS.py#42.
This is by no means a blocker, since it's not really necessary for anything on the FK Roadmap (farmOS/field-kit#373), and it can always be added at any time down the road w/o being a breaking change, but it's such low hanging fruit and a significant optimization it's worth considering.
The text was updated successfully, but these errors were encountered: