Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making linting possible with tslint and introducing declaration files #11

Closed
wants to merge 5 commits into from

Conversation

farooqkz
Copy link
Owner

@farooqkz farooqkz commented May 5, 2023

From what I understand, we need separate declaration files in a typescript project so that the user package can understand how is everything and what data it is supposed to feed functions, classes, etc.

This PR aims to provide the declarations files for KaiUIng-Inferno as well as a command to make linting possible with tslint.

This is a draft but reviews are very welcome.

@farooqkz farooqkz requested a review from Simon-Laux May 5, 2023 14:30
@Simon-Laux
Copy link
Collaborator

Simon-Laux commented May 6, 2023

you don't need extra d.ts files for each component, you can generate them with the official typescript compiler if parcel uses something else and is not able to output them, but maybe parcel already has an option to output declaration files, so I'd check the parcel documentation first.

@farooqkz farooqkz closed this May 10, 2023
@farooqkz farooqkz deleted the pr branch May 10, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants