Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for 298 #1

Merged
merged 2 commits into from
Nov 21, 2018
Merged

Fixes for 298 #1

merged 2 commits into from
Nov 21, 2018

Conversation

TomasTomecek
Copy link

No description provided.

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
 * decrease sleep times -> faster test suite
 * podman uses stopped instead of exited
 * port mapping doesn't work in rootless containers - remove such
   testing

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
@fasashen fasashen merged commit 5cafc82 into fasashen:podman Nov 21, 2018
@TomasTomecek TomasTomecek deleted the fixes-for-298 branch November 21, 2018 15:19
@fasashen
Copy link
Owner

@TomasTomecek you've changed keys for parsing container metadata to uppercase, but in my metadata the keys are lowercase: "id", not "ID".
So, I get KeyError: 'ID'.
Do you where the problem is?

@TomasTomecek
Copy link
Author

Oh my, so did they change the key names b/w versions or is the difference between rootless and root containers, I'll investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants