Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_verified_by_default unexpected keyword #1172

Closed
bert2002 opened this issue Mar 15, 2023 · 3 comments
Closed

is_verified_by_default unexpected keyword #1172

bert2002 opened this issue Mar 15, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@bert2002
Copy link

Describe the bug

Setting an Oauth account to verified by default, results in an error. Docs taken from here.

To Reproduce

app.include_router(
  fastapi_users.get_oauth_router(google_oauth_client, auth_backend, SECRET, is_verified_by_default=True,),
  prefix="/auth/google",
  tags=["auth"],
)

Error:

    fastapi_users.get_oauth_router(google_oauth_client, auth_backend, SECRET, is_verified_by_default=True,),
TypeError: get_oauth_router() got an unexpected keyword argument 'is_verified_by_default'

Configuration

  • FastAPI version : 0.94.0
  • FastAPI Users version : 10.4.0
@bert2002 bert2002 added the bug Something isn't working label Mar 15, 2023
@frankie567
Copy link
Member

Thank you for the report 🙏 I'll make a release in a few minutes with a fix.

frankie567 added a commit that referenced this issue Mar 15, 2023
Bug fixes & improvements
---------

* Fix #1172: missing `is_verified_by_default` argument on `get_oauth_router` method
* Bump dependencies:
    * `python-multipart ==0.0.6`
@bert2002
Copy link
Author

I saw you made the commit, but no release yet @frankie567 - or want to add something else to the release?

@frankie567
Copy link
Member

Yes, it was released on PyPi 5 days ago, just forgot to publish the notes on GitHub, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants