fix: don't send membership data for offline peers #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keeps leaf configs cleaner by removing offline peers, they should come back when they reconnect to a trust source, and thus membership data starts being sent again
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
==========================================
+ Coverage 86.98% 87.28% +0.30%
==========================================
Files 78 78
Lines 2742 2768 +26
==========================================
+ Hits 2385 2416 +31
+ Misses 216 213 -3
+ Partials 141 139 -2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keeps leaf configs cleaner by removing offline peers, they should come back
when they reconnect to a trust source, and thus membership data starts being
sent again