Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fallback erroring impl of AddAddr for unsupported platforms #24

Merged
merged 4 commits into from
Jul 15, 2021

Conversation

fastcat
Copy link
Owner

@fastcat fastcat commented Jul 15, 2021

instead of crashing out

@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #24 (f502506) into master (32c89b1) will decrease coverage by 0.19%.
The diff coverage is 73.68%.

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   86.95%   86.76%   -0.20%     
==========================================
  Files          79       80       +1     
  Lines        2828     2840      +12     
==========================================
+ Hits         2459     2464       +5     
- Misses        223      227       +4     
- Partials      146      149       +3     

@fastcat fastcat marked this pull request as ready for review July 15, 2021 23:32
@fastcat fastcat merged commit adf13e9 into master Jul 15, 2021
@fastcat fastcat deleted the fix/generic-platform-support branch July 15, 2021 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant