fix: disable route based trust when we have configured trust #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
having it enabled when a config file is in effect just makes things confusing, and can create unexpected results if the trust source reboots, where suddenly AIPs get added from systems from which they wouldn't be accepted normally
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
+ Coverage 86.08% 86.20% +0.11%
==========================================
Files 84 85 +1
Lines 2897 2921 +24
==========================================
+ Hits 2494 2518 +24
Misses 253 253
Partials 150 150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
having it enabled when a config file is in effect just makes things confusing, and can create unexpected results if the trust source reboots, where suddenly AIPs get added from systems from which they wouldn't be accepted normally