Use lazy fetch in MavenResolverIO when reading POMs from the DB
#472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proksch
approved these changes
Jun 8, 2022
…te tmp file if doesn't exist
… for using `MavenResolverIO` and fetching >1 million POMs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Specifically, this PR makes the following changes:
lazyFetch()inreadFromDB()to avoid loading lots of table rows in a list and causingOOM.AutoCommitto false when creating a PG connection in the REST API. This is needed as PG doesn't like non-zero fetch size andautocommit == falsetogether. See this for more info.Motivation and context
As described in #471, the Java REST API currently crashes due to
OOM, which is caused by reading all package versions' metadata into memory. This should be done lazily, i.e., one by one.Testing
Tested with the DC and within the IDE.
Also, with this fix, in production, the Java REST API is now responsive and the
OOMexception does not occur.