Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Fastify v5 #700

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Update for Fastify v5 #700

merged 2 commits into from
Apr 10, 2024

Conversation

synapse
Copy link

@synapse synapse commented Mar 19, 2024

Ref: fastify/fastify#5116

  • Removed the ts and jsx which are replaced by disabling the !@tapjs/typescript plugin.
  • branches, functions, lines and statements where dropped in v18 -> https://node-tap.org/changelog/
  • nyc were also dropped in v18
  • coverage is enabled by default in v18, disabling them via disable-coverage: true

Checklist

CC: @simoneb

@synapse synapse changed the base branch from master to next March 19, 2024 14:25
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gurgunday gurgunday changed the base branch from next to master April 10, 2024 12:39
@gurgunday gurgunday changed the base branch from master to next April 10, 2024 12:39
Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day>
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gurgunday gurgunday merged commit ce76e59 into fastify:next Apr 10, 2024
14 checks passed
jsumners pushed a commit that referenced this pull request Jun 21, 2024
Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day>
Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants