chore: warns the user appropriately for non-existent files

[jamesgeorge007]

Fixes #181

Shows up a warning rather than throwing the error.

[mcollina]

Would you mind applying the suggestion and adding a unit test?

[mcollina]

You can mock module.exports.stop and verify it's getting called.

[jamesgeorge007]

@mcollina It seems that 4 test cases are failing.

How should be the following error message be refactored 🤔

fastify-cli/test/start.test.js

Line 151 in f8ca00c

t.ok(/Cannot find module.*not-found/.test(err.message), err.message)

[mcollina]

You need to change

fastify-cli/start.js

Line 74 in f8ca00c

function stop (error) {

so that it accept a second parameter (a string), and you print that string in stop if the error is not provided. Then, you need to change your PR so that the message is passed as a second argument instead.

[jamesgeorge007]

@xtx1130 Can you draw a better picture regarding the failing tests and how should it be fixed up 🤔

[xtx1130]

@jamesgeorge007 I have got wrong, you need to accept mcollina's suggest, add another param to ensure stop support warning, such as :

function stop (error, warn) {
  if (error) {
    console.log(error)
    process.exit(1)
  }
  if (warn) {
   console.log(warn)
  }
  process.exit()
}

And you need to change:

return module.exports.stop(`${opts._[0]} doesn't exist within ${process.cwd()}`)

to

return module.exports.stop('', `${opts._[0]} doesn't exist within ${process.cwd()}`)

The test case should change to:

test('should throw on file not found', t => {
  t.plan(1)

  const oldStop = start.stop
  t.tearDown(() => { start.stop = oldStop })
  start.stop = function (err, warn) {
   // test case changes
    t.ok(/.*not-found doesn't exist within/.test(warn), warn)
  }

  const argv = [ '-p', getPort(), './data/not-found.js' ]
  start.start(argv)
})

[xtx1130]

@jamesgeorge007 There still have some test cases you need to deal with. You can run npm run test in your local environment to make sure the test cases is correct.

[jamesgeorge007]

@xtx1130 I'm not able to figure out what's going wrong with the currently failing tests. Any sort of help is appreciated 👏

[jamesgeorge007]

cc @xtx1130

[jamesgeorge007]

cc @mcollina

[mcollina]

LGTM