Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update standard #197

Merged
merged 2 commits into from
Aug 22, 2019
Merged

Update standard #197

merged 2 commits into from
Aug 22, 2019

Conversation

SerayaEryn
Copy link
Contributor

Closes #196

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

@xtx1130
Copy link
Contributor

xtx1130 commented Aug 22, 2019

Whether it is necessary to update packages major version?

mcollina
mcollina approved these changes Aug 22, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work!

@Eomm Eomm merged commit 8f2d3cc into fastify:master Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Eomm Eomm Eomm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SerayaEryn @xtx1130 @mcollina @Eomm