Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test cases for inspect #203

Merged
merged 2 commits into from
Sep 2, 2019
Merged

test: add test cases for inspect #203

merged 2 commits into from
Sep 2, 2019

Conversation

xtx1130
Copy link
Contributor

@xtx1130 xtx1130 commented Sep 2, 2019

Checklist

ref #202 , add test cases for that pr.

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

mcollina
mcollina reviewed Sep 2, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

test/start.test.js Outdated Show resolved Hide resolved
@xtx1130 xtx1130 marked this pull request as ready for review September 2, 2019 07:24
mcollina
mcollina approved these changes Sep 2, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 3befd11 into fastify:master Sep 2, 2019
@xtx1130 xtx1130 deleted the fix-inspect-testcase branch September 3, 2019 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xtx1130 @mcollina