Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing Typescript properties for namespaces #182

Merged
merged 3 commits into from
Oct 14, 2021
Merged

Fix missing Typescript properties for namespaces #182

merged 3 commits into from
Oct 14, 2021

Conversation

scantarbian
Copy link
Contributor

@scantarbian scantarbian commented Oct 14, 2021

Typescript throws error when adding namespace (#175) and related options. This is due to missing properties on FastifyJWTOptions interface.

Checklist

Typescript throws error when adding namespace (#175) and related options. This is due to missing properties on FastifyJWTOptions interface.
Copy link
Member

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@scantarbian
Copy link
Contributor Author

Using reply/request with namespace (e.g. request.customVerify) also throws error from FastifyRequest interface. However, I am unable to find any solution for this except making .d.ts file in @types folder locally.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit d3925dd into fastify:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants