Update for Fastify v5 #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I've deleted the old one because unused and created a new one, then rebased |
|
interesting that no tests are being triggered though |
Hmm, on my repo/branch they where run and all passed 🤔 |
|
can you check why they're not triggering here? |
Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day>
Fdawgs
approved these changes
Apr 15, 2024
jsumners
added a commit
that referenced
this pull request
Jul 19, 2024
* Update for Fastify v5 (#251) * upgrade for fastify 5 * added linting new line * enable coverage --------- Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day> Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day> * update fastify deps --------- Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day> Co-authored-by: Cristian Barlutiu <cristian.barlutiu@gmail.com> Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: fastify/fastify#5116
Checklist
npm run testandnpm run benchmarkand the Code of conduct
CC @simoneb