Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update references to old fastify-* modules #111

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Apr 29, 2022

See fastify/fastify#3733

Checklist

declare module 'fastify-request-context' {
declare module '@fastify/request-context' {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know enough about TS to know if this is okay?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's ok

declare module 'fastify-request-context' {
declare module '@fastify/request-context' {
Copy link
Member Author

@Fdawgs Fdawgs Apr 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know enough about TS to know if this is okay also?

@Fdawgs Fdawgs requested a review from a team April 29, 2022 13:06
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RafaelGSS
Copy link
Member

just double check @fastify/typescript

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 9f58363 into master Apr 29, 2022
@Fdawgs Fdawgs deleted the docs/org-name branch April 29, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants