Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added AsyncResource factory function option #173

Merged
merged 1 commit into from
Jan 6, 2024
Merged

feat: added AsyncResource factory function option #173

merged 1 commit into from
Jan 6, 2024

Conversation

imjuni
Copy link
Contributor

@imjuni imjuni commented Dec 13, 2023 •
edited
Loading

Checklist

@imjuni imjuni mentioned this pull request Dec 14, 2023
Closed
2 tasks
@Eomm
Copy link
Member

Eomm commented Dec 18, 2023

Could you update the PR?
The CI should be green now

@Eomm Eomm linked an issue Dec 18, 2023 that may be closed by this pull request
Customizable AsyncResource.type and create-resource #172
Closed
2 tasks
@imjuni imjuni closed this Dec 19, 2023
@imjuni imjuni reopened this Dec 19, 2023
@imjuni
Copy link
Contributor Author

imjuni commented Dec 19, 2023

Updated

mcollina
mcollina approved these changes Dec 24, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@imjuni
Copy link
Contributor Author

imjuni commented Jan 5, 2024

Is there anything else I should do?

@mcollina mcollina merged commit 5122a18 into fastify:master Jan 6, 2024
40 checks passed
@mcollina
Copy link
Member

mcollina commented Jan 6, 2024

Nope, it's in our queue for shipping a releass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Customizable AsyncResource.type and create-resource
3 participants
@imjuni @Eomm @mcollina