Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds support to externalDocs per route when using OAS 2.0 and updates FastifySchema interface #527

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

riquenunes
Copy link
Contributor

@riquenunes riquenunes commented Jan 19, 2022

This pull request adds the possibility of specifying an externalDocs object per route when using OAS 2.0 (as described here) and also exposes this option in the FastifySchema interface.

This was already supported by the library when using OAS 3.0 (as seen here), but was not exposed in the FastifySchema interface and was also not available when using OAS 2.0.

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1715756395

  • 0 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 1672154250: 0.0%
Covered Lines: 636
Relevant Lines: 636

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jan 19, 2022

Pull Request Test Coverage Report for Build 1715756395

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 1672154250: 0.0%
Covered Lines: 636
Relevant Lines: 636

💛 - Coveralls

Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@climba03003 climba03003 merged commit 0e26517 into fastify:master Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants