Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow openapi version to be overridden #602

Merged
merged 2 commits into from
May 30, 2022
Merged

fix: allow openapi version to be overridden #602

merged 2 commits into from
May 30, 2022

Conversation

TimonVS
Copy link
Contributor

@TimonVS TimonVS commented May 27, 2022

Fixes #601

@mcollina mcollina requested review from climba03003 and Eomm and removed request for climba03003 May 27, 2022 10:14
@TimonVS
Copy link
Contributor Author

TimonVS commented May 27, 2022 •
edited
Loading

I’ll fix the linting error tomorrow when I’m behind a computer :) Fixed.

climba03003
climba03003 reviewed May 30, 2022
View reviewed changes
lib/spec/openapi/utils.js Outdated Show resolved Hide resolved
lib/spec/openapi/utils.js Outdated Show resolved Hide resolved
mcollina
mcollina reviewed May 30, 2022
View reviewed changes
lib/spec/openapi/utils.js Outdated Show resolved Hide resolved
mcollina
mcollina approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TimonVS
Copy link
Contributor Author

TimonVS commented May 30, 2022

@mcollina this MR targets the master branch, which only supports Fastify v4. Should I open an MR to the 6.x branch (doesn't exist yet) to backport the fix for Fastify v3 support?

climba03003
climba03003 approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mcollina mcollina merged commit a033619 into fastify:master May 30, 2022
@mcollina
Copy link
Member

@mcollina this MR targets the master branch, which only supports Fastify v4. Should I open an MR to the 6.x branch (doesn't exist yet) to backport the fix for Fastify v3 support?

I've created a 6.x branch, go ahead!

TimonVS added a commit to TimonVS/fastify-swagger that referenced this pull request May 30, 2022
@TimonVS
fix: allow openapi version to be overridden (fastify#602)
bcc9608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@climba03003 climba03003 climba03003 approved these changes

@mcollina mcollina mcollina approved these changes

@Eomm Eomm Awaiting requested review from Eomm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot set OpenAPI version
3 participants
@TimonVS @mcollina @climba03003