Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing SwaggerOptions.uiConfig.supportedSubmitMethods issue 626 #627

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Added missing SwaggerOptions.uiConfig.supportedSubmitMethods issue 626 #627

merged 1 commit into from
Jun 29, 2022

Conversation

roeeyud
Copy link
Contributor

@roeeyud roeeyud commented Jun 29, 2022

Fix for Missing Type issue: #626

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added - Don't think that's needed (correct me if I'm wrong)
  • commit message and code follows the Developer's Certification of Origin
    and the Code of conduct

Now I'm worried I don't have a proper Certification of Origin

Thanks for all the amazing work on Fastify!

mcollina
mcollina approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 5590c91 into fastify:master Jun 29, 2022
@roeeyud roeeyud deleted the fix/626/supportedSubmitMethods_missing branch June 29, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roeeyud @mcollina