fix(lib): polynomial redos routes #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurgunday
reviewed
Oct 21, 2023
lib/spec/openapi/utils.js
Outdated
| @@ -88,7 +88,7 @@ function normalizeUrl (url, serverUrls, stripBasePath) { | |||
|
|
|||
| function resolveServerUrls (servers) { | |||
| const resolvedUrls = [] | |||
| const findVariablesRegex = /{(.*?)}/g // As for OpenAPI v3 spec url variables are named in brackets, e.g. {foo} | |||
| const findVariablesRegex = /\{(.*?)\}/gu // As for OpenAPI v3 spec url variables are named in brackets, e.g. {foo} | |||
There was a problem hiding this comment.
Was the escape necessary?
Just curious
There was a problem hiding this comment.
Without it they are treated as part of a quantifier.
|
@Fdawgs CodeQL is complaining about this regexp, could you take a look? |
Fdawgs
force-pushed
the
refactor/regex
branch
from
9376349
to
45ab836
Compare
Fdawgs
changed the title
u unicode flag to regex
This appears to have been an issue prior to this change (if you look in the Security tab of the repo). |
Fdawgs
force-pushed
the
refactor/regex
branch
from
d26d6a2
to
698c66a
Compare
Fdawgs
changed the title
|
Found another one in 698c66a that CodeQL didn't pick up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See fastify/fastify-autoload#330
Checklist
npm run testandnpm run benchmarkand the Code of conduct