Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve examples for shared schemas #786

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Resolve examples for shared schemas #786

merged 3 commits into from
Mar 20, 2024

Conversation

vascofg
Copy link
Contributor

@vascofg vascofg commented Mar 7, 2024

The examples keyword is never transformed to example for shared schemas (added via fastify.addSchema and referred with $ref).

This PR calls the appropriate function on preparation of these shared schemas.

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina requested a review from Eomm March 7, 2024 10:19
@mcollina mcollina merged commit fedf75c into fastify:master Mar 20, 2024
19 checks passed
@vascofg
Copy link
Contributor Author

vascofg commented May 3, 2024

Any chance you can release a new version anytime soon, including these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants